Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between Added and Removed #133

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Distinguish between Added and Removed #133

merged 2 commits into from
Oct 22, 2023

Conversation

masesdevelopers
Copy link
Collaborator

Description

Removed Upserted case

Related Issue

Fix #119

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request KEFCore The issue is releated to KEFCore labels Oct 22, 2023
@masesdevelopers masesdevelopers self-assigned this Oct 22, 2023
@masesdevelopers masesdevelopers changed the title Dustinguish between Added and Removed Distinguish between Added and Removed Oct 22, 2023
@masesdevelopers masesdevelopers merged commit fc08423 into masesgroup:master Oct 22, 2023
4 checks passed
@masesdevelopers masesdevelopers deleted the 119-add-some-event-handlers-to-report-to-the-user-events-about-changes-4 branch October 22, 2023 01:08
@masesdevelopers
Copy link
Collaborator Author

Shall be reverted because it is not possible to distinguish between an Added or Modified record: KNet raise the event after it made the update.

@masesdevelopers masesdevelopers mentioned this pull request Oct 22, 2023
Closed
masesdevelopers added a commit to masesdevelopers/EntityFramework4Kafka that referenced this pull request Oct 22, 2023
@masesdevelopers
Reverted masesgroup#133
46aaf9b
@masesdevelopers masesdevelopers mentioned this pull request Oct 22, 2023
Merged
9 tasks
masesdevelopers added a commit that referenced this pull request Oct 22, 2023
@masesdevelopers
Reverted #133 (#134)
a1fb8af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@masesdevelopers masesdevelopers

Labels
enhancement New feature or request KEFCore The issue is releated to KEFCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some event handlers to report to the user events about changes
1 participant
@masesdevelopers